Fix lint issue on the html.DataAttr test - #333
Merged
markuswustenberg merged 2 commits intoJul 29, 2026
Merged
Conversation
The govet `inline` check flags direct calls of functions marked `//go:fix inline`, so exercise `html.DataAttr` through a function value in a test table, like the other deprecated aliases.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 639 639
=========================================
Hits 639 639 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
markuswustenberg
added a commit
that referenced
this pull request
Jul 29, 2026
- Add `docs/diary/2026-07-29-issue-330-docs-and-security-policy.md`, an implementation diary covering the #330 assessment and the three resulting PRs (#331, #332, #333) — including the subagent worktree stale-base incident and other failures worth remembering. - First entry in a new `docs/diary/` directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
golangci-lint(govet'sinlinecheck, with recent versions) flags the directDataAttrcall inTestData, sinceDataAttris marked//go:fix inline. CI lints withversion: latest, so this fails there too.TestDatainto a table exercisingDataandDataAttrthrough function values, the same wayStyleAttr,TitleAttr,CiteEl,FormEl, andLabelElare already tested. Coverage ofDataAttris unchanged, nonolintneeded.