🛡️ Sentinel: [CRITICAL] Fix SQL injection in SQLite PRAGMA - #299
🛡️ Sentinel: [CRITICAL] Fix SQL injection in SQLite PRAGMA#299mapleleaflatte03 wants to merge 4 commits into
Conversation
…ration Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ration Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
…ration Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
…ration Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
🚨 Severity: CRITICAL
💡 Vulnerability: The
MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEenvironment variable was directly interpolated into an SQLitePRAGMAstatement without proper allowlisting. Since SQLitePRAGMAqueries cannot be parameterized, this exposed a SQL injection vulnerability via configuration poisoning.🎯 Impact: An attacker who can control this environment variable could inject arbitrary SQLite configurations or trigger SQL syntax errors, potentially bypassing intended observability database rules.
🔧 Fix: Implemented strict allowlisting for the journal mode configuration. The value is now checked against a set of explicitly valid modes (
'DELETE','TRUNCATE','PERSIST','MEMORY','WAL','OFF','','DEFAULT'). If an invalid value is supplied, it safely defaults to'WAL'.✅ Verification: Ran the
intelligencetest suite. Verified that the fallback to'WAL'occurs securely and that valid configurations are correctly processed.PR created automatically by Jules for task 4602589750294193991 started by @mapleleaflatte03