π‘οΈ Sentinel: [CRITICAL] Fix SQL injection risk in SQLite PRAGMA configuration - #294
π‘οΈ Sentinel: [CRITICAL] Fix SQL injection risk in SQLite PRAGMA configuration#294mapleleaflatte03 wants to merge 4 commits into
Conversation
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
π¨ Severity: CRITICAL
π‘ Vulnerability: SQL injection was possible through an unvalidated environment variable
MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEwhen dynamically generating thePRAGMA journal_mode=...statement inintelligence/company/meridian_platform/observability_store.py. Because thesqlite3module does not support parameterized query execution (?) forPRAGMAstatements, the environment variable was directly interpolated into the SQL string, creating an injection vector.π― Impact: A malicious actor who gained the ability to modify environment variables on the host could execute arbitrary SQL statements against the observability stream database by injecting statements like
OFF; DROP TABLE audit_events;--as the journal mode, resulting in complete database compromise.π§ Fix: Implemented an explicit validation allowlist for
MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE. The value is now strictly checked against a known-safe set of valid SQLite journal modes (DELETE,TRUNCATE,PERSIST,MEMORY,WAL,OFF) and allowed fallback values ('',DEFAULT). If the supplied value is not in the allowlist, the code safely defaults toWAL.β Verification: Ran the Meridian Platform unit test suite (
python3 -m unittest discover -s intelligence/company/meridian_platform -p "test_*.py") and confirmed no new failures were introduced. Code review was passed.PR created automatically by Jules for task 3700974545461866479 started by @mapleleaflatte03