π‘οΈ Sentinel: [HIGH] Fix SQL injection vector in PRAGMA statement - #290
π‘οΈ Sentinel: [HIGH] Fix SQL injection vector in PRAGMA statement#290mapleleaflatte03 wants to merge 4 commits into
Conversation
Validated the `MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE` environment variable against a strict allowlist of explicit, acceptable values before interpolating it into a PRAGMA query. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Validated the `MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE` environment variable against a strict allowlist of explicit, acceptable values before interpolating it into a PRAGMA query. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Validated the `MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE` environment variable against a strict allowlist of explicit, acceptable values before interpolating it into a PRAGMA query. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Validated the `MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE` environment variable against a strict allowlist of explicit, acceptable values before interpolating it into a PRAGMA query. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: SQL injection vector via dynamically generated PRAGMA query in
observability_store.py. TheMERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEenvironment variable was interpolated directly intoconn.execute(f'PRAGMA journal_mode={configured_journal_mode}')without strict allowlisting.π― Impact: A malicious actor who can control the environment variable could pass malformed strings or additional statements (though
execute()limits to one statement, it still allows invalid PRAGMA values or potential engine crashes) due to the lack of parameterized queries for PRAGMAs.π§ Fix: Added a strict validation check using an explicit allowlist of acceptable SQLite journal modes (
'DELETE','TRUNCATE','PERSIST','MEMORY','WAL','','DEFAULT','OFF').β Verification: Ran unit tests to ensure no regressions were introduced. Evaluated manually by attempting to inject invalid strings, which correctly fallback to 'WAL'.
PR created automatically by Jules for task 1407202302671966321 started by @mapleleaflatte03