🛡️ Sentinel: [CRITICAL] Fix SQL injection in SQLite PRAGMA execution - #284
🛡️ Sentinel: [CRITICAL] Fix SQL injection in SQLite PRAGMA execution#284mapleleaflatte03 wants to merge 4 commits into
Conversation
…ity_store.py Sanitizes MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE env variable by strictly checking against an allowlist before using it in a SQLite PRAGMA journal_mode statement. PRAGMA statements cannot use standard parameterized binding, making the allowlist necessary to prevent injection. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
…ity_store.py Sanitizes MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE env variable by strictly checking against an allowlist before using it in a SQLite PRAGMA journal_mode statement. PRAGMA statements cannot use standard parameterized binding, making the allowlist necessary to prevent injection. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
…ity_store.py Sanitizes MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE env variable by strictly checking against an allowlist before using it in a SQLite PRAGMA journal_mode statement. PRAGMA statements cannot use standard parameterized binding, making the allowlist necessary to prevent injection. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
…ity_store.py Sanitizes MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE env variable by strictly checking against an allowlist before using it in a SQLite PRAGMA journal_mode statement. PRAGMA statements cannot use standard parameterized binding, making the allowlist necessary to prevent injection. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: SQL injection via the
MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEenvironment variable when it is directly interpolated into aPRAGMA journal_mode=statement inobservability_store.py.🎯 Impact: An attacker who can control or influence environment variables could append arbitrary commands or close standard configuration contexts, leading to arbitrary SQLite operations.
🔧 Fix: Validates the value of
MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEstrictly against an explicit allowlist (e.g.,DELETE,TRUNCATE,PERSIST,MEMORY,WAL,OFF) before using it.✅ Verification: Tested locally via isolated test script and verified existing observability_store unit tests execute without new regressions. Recorded learning in
.jules/sentinel.md.PR created automatically by Jules for task 17119553243169270238 started by @mapleleaflatte03