Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SQL injection in PRAGMA statement - #282

Open
mapleleaflatte03 wants to merge 1 commit into
mainfrom
fix-pragma-sql-injection-10615744975384078154
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix SQL injection in PRAGMA statement#282
mapleleaflatte03 wants to merge 1 commit into
mainfrom
fix-pragma-sql-injection-10615744975384078154

Conversation

@mapleleaflatte03

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL

πŸ’‘ Vulnerability: SQL injection vulnerability in observability_store.py where the MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE environment variable was directly interpolated into a PRAGMA journal_mode={...} SQL statement without validation.

🎯 Impact: Since PRAGMA statements do not support parameterized queries (?), unvalidated dynamic input allows executing arbitrary SQL statements by appending them separated by semicolons. This could result in bypassing security controls or modifying underlying data.

πŸ”§ Fix: Instead of direct string interpolation, the dynamic journal mode value is strictly validated against an explicit allowlist of known-safe SQLite journal modes (and accepted historical bypasses). Unknown values default to a safe value (WAL).

βœ… Verification: Ensured via code logic that the environment variable input can only take safely predefined values before executing PRAGMA. Unit tests via PYTHONPATH=intelligence/company/meridian_platform python3 -m unittest discover -s intelligence/company/meridian_platform -p "test_alerting.py" execute and pass without regressions.


PR created automatically by Jules for task 10615744975384078154 started by @mapleleaflatte03

Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant