π‘οΈ Sentinel: [HIGH] Fix SQL injection in PRAGMA journal_mode statement - #279
π‘οΈ Sentinel: [HIGH] Fix SQL injection in PRAGMA journal_mode statement#279mapleleaflatte03 wants to merge 4 commits into
Conversation
SQLite `PRAGMA` statements do not support parameterized queries. The application dynamically constructed `PRAGMA journal_mode` using an environment variable without strict validation against an allowlist, posing a risk of SQL injection. This commit adds an explicit allowlist check. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
SQLite `PRAGMA` statements do not support parameterized queries. The application dynamically constructed `PRAGMA journal_mode` using an environment variable without strict validation against an allowlist, posing a risk of SQL injection. This commit adds an explicit allowlist check. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
SQLite `PRAGMA` statements do not support parameterized queries. The application dynamically constructed `PRAGMA journal_mode` using an environment variable without strict validation against an allowlist, posing a risk of SQL injection. This commit adds an explicit allowlist check. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
SQLite `PRAGMA` statements do not support parameterized queries. The application dynamically constructed `PRAGMA journal_mode` using an environment variable without strict validation against an allowlist, posing a risk of SQL injection. This commit adds an explicit allowlist check. Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: The SQLite
PRAGMA journal_modestatement is dynamically constructed using theMERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODEenvironment variable. BecausePRAGMAstatements do not support standard SQL parameterization, directly concatenating user-controlled or external input into these statements can lead to SQL injection.π― Impact: While environment variables are typically controlled by operators, any scenario where an attacker might influence this variable could allow them to execute arbitrary SQLite commands (e.g., dropping tables, modifying database structure, or exfiltrating data) through a chained injection.
π§ Fix: Introduced a strict allowlist of valid SQLite journal modes (
DELETE,TRUNCATE,PERSIST,MEMORY,WAL,OFF, ``,DEFAULT). If the configured mode is not in the allowlist, it securely defaults to `WAL`.β Verification:
test_injection.pyto confirm that appending malicious SQL commands to the environment variable no longer executes successfully.PYTHONPATH=intelligence/company/meridian_platform python3 -m unittest discover -s intelligence/company/meridian_platform -p "test_*.py") confirm normal database connectivity functions seamlessly without regression.PR created automatically by Jules for task 16881048076431060591 started by @mapleleaflatte03