🎨 Palette: Add tooltips and keyboard accessibility to disabled bulk actions - #277
🎨 Palette: Add tooltips and keyboard accessibility to disabled bulk actions#277mapleleaflatte03 wants to merge 4 commits into
Conversation
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
💡 What: Wrapped disabled bulk-action buttons (
approve,stale,revoke,unresolved) inintelligence/company/www/trust-ops.htmlwith a<span class="operator-action-wrapper" style="display: inline-block;">element that holds atitleand dynamictabindex="0". JavaScript dynamically toggles thetabindexandtitleattributes based on whether items are selected (and the button is disabled vs. enabled). Added a journal entry for this UX learning.🎯 Why: Native
titleattributes ondisabledelements do not work because they don't capture pointer events in most major browsers. This left users without an explanation for why the buttons were disabled ("Select items to apply decision").📸 Before/After: Before, hovering or tabbing to the disabled bulk action buttons did nothing and provided no context. After, wrapping spans catch the pointer events and focus, showing the tooltip correctly. When the buttons become enabled, the
titleandtabindexare removed to prevent a confusing double tab stop and stale tooltip.♿ Accessibility: Added
tabindex="0"on the disabled wrapper state so keyboard users can focus the element and read the tooltip. The script removes thetabindexwhen the button is enabled to ensure there is only one logical focus stop (the button itself) per action.PR created automatically by Jules for task 644469080325245200 started by @mapleleaflatte03