Skip to content

🛡️ Sentinel: [CRITICAL] Fix SQL injection in SQLite PRAGMA configuration - #276

Open
mapleleaflatte03 wants to merge 2 commits into
mainfrom
sentinel-fix-pragma-injection-15337542983911085825
Open

🛡️ Sentinel: [CRITICAL] Fix SQL injection in SQLite PRAGMA configuration#276
mapleleaflatte03 wants to merge 2 commits into
mainfrom
sentinel-fix-pragma-injection-15337542983911085825

Conversation

@mapleleaflatte03

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
💡 Vulnerability: SQL injection vulnerability via the MERIDIAN_OBSERVABILITY_SQLITE_JOURNAL_MODE environment variable in observability_store.py. PRAGMA statements in sqlite3 do not support parameterized queries, so direct concatenation of environment variables into the PRAGMA query string allows SQL injection.
🎯 Impact: An attacker who can control or influence this environment variable could inject arbitrary SQL commands or manipulate SQLite connection behavior, leading to data corruption or potentially further compromise depending on the execution context.
🔧 Fix: Implemented strict validation of the dynamically generated PRAGMA input against an explicit allowlist of valid SQLite journal modes ('DELETE', 'TRUNCATE', 'PERSIST', 'MEMORY', 'WAL', 'OFF', 'DEFAULT', ''). Invalid values safely fall back to the default 'WAL' mode.
✅ Verification: Tested the new logic locally by attempting to inject malicious PRAGMA payloads and verifying the fallback logic successfully mitigates the injection while still allowing valid modes to function correctly. Also successfully ran the core test suite (PYTHONPATH=intelligence/company/meridian_platform python3 -m unittest discover -s intelligence -p "test_*.py") with no new regressions.


PR created automatically by Jules for task 15337542983911085825 started by @mapleleaflatte03

…ration

Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…ration

Co-authored-by: mapleleaflatte03 <240846662+mapleleaflatte03@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant