Skip to content

Small improvements - #47

Closed
debnet wants to merge 6 commits into
manosim:masterfrom
debnet:master
Closed

Small improvements#47
debnet wants to merge 6 commits into
manosim:masterfrom
debnet:master

Conversation

@debnet

@debnet debnet commented Jan 4, 2016

Copy link
Copy Markdown
  • Fixing displayed URL by using pattern instead of name_parent regex (for namespaced URLs mainly)
  • Distinction between custom API views and RESTFul APIs generated through models and routers
  • Adding possibility to use app_name in URL patterns for API organisation
  • Adding an URL to filter APIs by app_name or name_parent

Maxence and others added 3 commits December 22, 2015 17:24
Added the possibility to filter by application name in the url + modifed the name_parent's value of the ApiEndpoint
@debnet

debnet commented Jan 4, 2016

Copy link
Copy Markdown
Author

Tests added for the new features

@manosim

manosim commented Jan 4, 2016

Copy link
Copy Markdown
Owner

A few small bits:

  • When in /docs/app_name/ can we hide the "Jump to" dropdown from the navbar?
  • Link each app name(heading) to that url? (Maybe on hover show an # that links to that url - or something similar)
  • What if there is no defined app_name for a namespace? Would be great if we can use something like the parent so that it works with all the namespaces.

Other than that it looks great! Can't wait to merge it ✨

@debnet

debnet commented Jan 5, 2016

Copy link
Copy Markdown
Author

OK, we are working on it. ;)

Maxence added 3 commits January 5, 2016 15:25
- Add link to the ''/docs/[filter_name]''  for each group.grouper (name_parent)
- Parameter in the 'docs/filter_name' now works with app_name or namespace
- WARNING: Modify the urlpatterns for django version >= 1.9 (see deprecated use of app_name : https://docs.djangoproject.com/en/1.9/ref/urls/#include)
@debnet

debnet commented Jan 5, 2016

Copy link
Copy Markdown
Author

Done. Just to do some styling on title hyperlinks, we leave it to you. ;)

Exemple:

h1 {
   > a {
       color:#2C3E50 ;
       &:hover {
           text-decoration: none;
       }
   }
}

@manosim

manosim commented Jan 5, 2016

Copy link
Copy Markdown
Owner

Thank you @debnet! Moving this one to #48. 🎉

@manosim manosim closed this Jan 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants