fix: sync foreign toplevel visibility with tags#951
Open
EzequielColungaAcha wants to merge 1 commit into
Open
Conversation
Waybar's wlr/taskbar relies on foreign-toplevel output enter/leave events to decide which windows belong on a bar. Mango previously announced every client on its monitor even when the client's tags were not visible, so taskbars showed windows from other tags. Track whether each foreign toplevel has been announced to its output and resync that state when tag visibility, monitor assignment, minimization, or restoration changes. Minimized clients use their restore tag so they can stay visible in the taskbar for the tag they belong to and be restored from the taskbar. Co-authored-by: Cursor <cursoragent@cursor.com>
Author
|
Basically, used with wlr/taskbar it shows the windows open on the current tag only, making the click to minimize/maximize work as in DWM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
src/mango.candsrc/ext-protocol/foreign-toplevel.h.Made with Cursor