Reset CPU registers, EFLAGS, and stack memory between runs#315
Merged
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
williballenthin
force-pushed
the
fix/reset-run-context
branch
from
July 24, 2026 10:10
c4d0670 to
e8b8bc0
Compare
williballenthin
force-pushed
the
fix/reset-run-context
branch
from
July 24, 2026 10:15
e8b8bc0 to
2395d8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
all_entrypoints=TruePreviously, only ESP/EBP were reset between runs. The remaining CPU state (GP registers, EFLAGS, stack contents) was inherited from the prior run. This caused silent corruption (e.g., DF bleed breaking
rep movs), order-dependent results, and non-reproducible reports.Closes #304
Closes #305
Test plan
test_registers_reset_between_runs(x86 + x64): hooks first instruction of each run, asserts GP registers are zeroed and DF is cleartest_stack_cleared_between_runs: asserts 256 bytes below SP are zeroed at the start of each subsequent run🤖 Generated with Claude Code