Skip to content

Allow Multiple SMB Dialects#35

Open
ahm3dgg wants to merge 1 commit into
mandiant:mainfrom
ahm3dgg:allow-multiple-smb-dialects
Open

Allow Multiple SMB Dialects#35
ahm3dgg wants to merge 1 commit into
mandiant:mainfrom
ahm3dgg:allow-multiple-smb-dialects

Conversation

@ahm3dgg
Copy link
Copy Markdown

@ahm3dgg ahm3dgg commented Jun 5, 2026

Sticking to SMB 2.1.0 causes SMB Negotiate to fail on old windows server versions, the smb2 package allows for more if not specified

type Negotiator struct {
        // ....
	SpecifiedDialect      uint16   // if it's zero, clientDialects is used. (See feature.go for more details)
}

@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 5, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant