fix: use Qt flag_val() for PySide6 compat in IDA plugin#3096
fix: use Qt flag_val() for PySide6 compat in IDA plugin#3096BHARATH0153 wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
There was a problem hiding this comment.
Code Review
This pull request introduces compatibility fixes for Qt5 and Qt6 (PySide6) flag handling by introducing a flag_val helper function to extract raw integer values from Qt enum flags, and wrapping bitwise operations on flags with int() and flag_val(). The review feedback highlights a potential regression in qt_get_item_flag_tristate() where removing the direct check for ItemIsAutoTristate on Qt might break compatibility with certain PySide6 versions, and suggests restoring this check while wrapping all returned flags in flag_val().
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
CHANGELOG updated or no update needed, thanks! 😄
8b01034 to
bd8403b
Compare
bd8403b to
594c1cc
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Resolves #3095
Replace direct bitwise operations on module-level Qt flag constants with flag_val() helper that extracts int values from enum members. This resolves RuntimeWarning in IDA 9.3+ where PyQt5 shim is deprecated.
[x] No CHANGELOG update needed