Docs: strip 26 placeholder screenshots for 1.0 ship (captures tracked in #920)#921
Conversation
Code ReviewSummary: Pure docs cleanup — removes 26 never-captured What this doesStrips all
Total: 26 removed — matches the PR title. ✅ IssuesOne orphaned HTML comment in The image tag for Everything else
VerdictApprove with one minor fix: remove the orphaned |
Seven guides referenced placeholder-*.png images that were never captured; with no graceful fallback in the publish pipeline they'd render as broken <img> icons on the public guide pages. Removed the image lines (and their paired <!-- Screenshot: --> comments) so the prose + ASCII UI mockups stand on their own. Real, existing screenshots are untouched. The exact capture list (guide, filename, alt-text describing what to shoot) is preserved in #920 for 1.1 — "always be done": ship clean now, add the real captures in the next release. Guides affected: installation-wizard (4), vallack-nav (7), remapping (4), qmk-import (3), script-execution (3), window-management (3), layers (2). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
42f0107 to
8755d07
Compare
|
Code Review PR 921: Strip 26 placeholder screenshots for 1.0 Overall: Clean docs-only PR. The approach is correct -- prose and ASCII mockups stand on their own. One small inconsistency to fix before merge. SUMMARY ISSUE: Orphaned HTML comment in guides/vallack-nav.md Every other placeholder in this PR removes both the HTML comment AND the image tag. There is one exception: in vallack-nav.md, the comment about the CAGS vs Vallack modifier comparison diagram is left behind while its image tag is deleted. Per the PR goal of letting prose stand on its own, the comment should be removed too -- consistent with all other hunks. The 1.1 capture is already tracked in PR 920. Fix: Remove the leftover HTML comment line in vallack-nav.md. WHAT LOOKS GOOD
SUGGESTIONS (non-blocking)
VERDICT: Approve pending removal of the orphaned HTML comment in vallack-nav.md. |
…he RC 8 of 10 gates closed. Countdown to 0 (TODAY). Verdict → 'Shipping today': cmd-removal + screenshot cleanup merged after gating two runner flakes (#922). Gate 7 (RC) now in-progress; gate 9 closed (screenshots stripped/preserved via #921/#920); gate 8 finalizing with qualified import framing. Also fixes the system category count (3, not the review-flagged 1).
* Dashboard: Friday morning state — all Thu work merged, today is notes + screenshots 6 of 10 gates closed. Thursday's two Neovim detail-page bugs (#903 wrong component, #908 sheet clipping) are on master. Verdict + schedule updated to Friday: gates 8 (notes) and 9 (screenshot pass) close today, ~1h total; gate 7 RC + gate 10 video on Sat. Countdown to 1 day. * Dashboard: fix system category count clobbered by countdown replace The Fri-AM countdown edit globally replaced <span class=num>2</span> and accidentally knocked the 'system' category bar from its (already wrong) 2 down to 1. Real count is 3 (macOS Function Keys, Leader Key, Fast Navigation); categories now sum to 22 again. Caught by codex + claude review on #910. * Dashboard: Saturday release-day state — #899 + #921 merged, cutting the RC 8 of 10 gates closed. Countdown to 0 (TODAY). Verdict → 'Shipping today': cmd-removal + screenshot cleanup merged after gating two runner flakes (#922). Gate 7 (RC) now in-progress; gate 9 closed (screenshots stripped/preserved via #921/#920); gate 8 finalizing with qualified import framing. Also fixes the system category count (3, not the review-flagged 1). * Dashboard: Saturday release-day — burndown, verdict, footer to current Burndown now plots actual through Sat (no leftover Thu projection): Sat is the current marker near the floor; ~3h of execution left (RC + smoke + publish), not feature work. Verdict reflects release-prep #923 merged (version → 1.0.0/build 4, appcast + squatting-tag cleanup) with the signed RC building. Footer timestamp Wed → Sat 2026-06-13; drops the overclaimed "auto-synced" wording (it's hand-maintained). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * Dashboard: note overlay picker blocker found + fixed in RC QA (#924) RC QA surfaced the overlay output-type picker being unclickable; root-caused to WindowAnchoredPopover's identity-only Equatable discarding content updates, fixed and reworked into a drill-down with Launch App search (#924). Verdict now reflects re-cutting the RC from master with the fix. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Removes never-captured
placeholder-*.pngreferences from 7 guides so they don't render as broken images on the public site for 1.0. Prose + ASCII mockups stand on their own; real screenshots untouched. Exact capture list preserved in #920 for 1.1. Docs only.