Fix Neovim Terminal detail sheet clipping (add to wide-pack width list)

[malpern]

Second finding from Micah's visual review of the Neovim Terminal detail page (#903 fixed the wrong-component issue; this fixes the layout).

Problem

The detail sheet rendered at the 560pt default width while MappingTableContent's five columns (Key / Description / Action / +Shift / +Ctrl) need the 760pt wide layout — content clipped on both edges: icon half-cut, description truncated, +Ctrl column running off-screen.

Cause

Pack.preferredDetailWidth keeps a hardcoded wide-pack allowlist. Every other table-style pack (Vim Navigation, Mission Control, Numpad, Symbol, Fun) is listed; neovim-terminal wasn't. Same add-a-pack-forget-the-side-table class of bug as the orange-box issue — just a different side table.

Fix

One line: add com.keypath.pack.neovim-terminal to the set, plus a comment warning the next table-pack author. (A follow-up could derive width from the rendering branch instead of an allowlist — out of scope for release week.)

Verification

• Built + quick-deployed; awaiting Micah's visual re-check at 760pt
• Sequences pack intentionally not added: its detail is description-only (no table), so the 560 default fits
• The trailing_comma lint warning on the set literal is pre-existing file style

[claude]

Code Review

Overview: One-line bugfix adding com.keypath.pack.neovim-terminal to the widePacks allowlist so its detail sheet renders at 760pt instead of the clipped 560pt default. Minimal, targeted, and clearly described.

---

What's Good

• Fix is correct and surgical — exactly the right scope for release week.
• PR description thoroughly explains the problem, cause, fix, and what was intentionally excluded (Sequences pack).
• Pre-existing lint warning noted proactively rather than silently ignored.

---

Findings

1. Comment contains a historical reference that will rot (minor)

CLAUDE.md calls out: "Don't reference the current task, fix, or callers … since those belong in the PR description and rot as the codebase evolves." The parenthetical (Neovim Terminal shipped clipped…) is the incident note — it belongs in the commit message (where it already is) but not in the source. As packs are added and the set grows, that historical sentence will just confuse future readers.

Suggested trim:

// Table-style packs render MappingTableContent (five columns) and need
// the wide layout. When adding a new table-style pack, add it here too
// or its detail sheet will clip horizontally at the 560pt default.

2. No test coverage for the allowlist (low-priority, worth tracking)

The neovim-terminal omission was caught only by visual review. A unit test asserting which pack IDs use the wide layout would have caught the regression automatically. Not a blocker, but worth filing as a follow-up given the whole class of bug is now documented in the comment.

3. Allowlist pattern is acknowledged tech debt (noted, not blocking)

The PR body already flags this: "A follow-up could derive width from the rendering branch instead of an allowlist." Worth filing a ticket so it does not get lost between releases.

---

Verdict

Approve with suggestions — the fix is correct and safe to merge. The comment nit is the only thing worth addressing before merging; the test and refactor can be tracked as follow-ups.

[claude]

Code Review

One-liner fix for a real visual bug — correct and minimal. Two findings worth addressing before merge.

---

What the PR does

Adds com.keypath.pack.neovim-terminal to the widePacks allowlist in preferredDetailWidth so the Neovim Terminal detail sheet renders at 760pt instead of the 560pt default, preventing horizontal clipping of the five-column MappingTableContent.

---

Findings

1. Comment length violates project conventions (minor)

CLAUDE.md says: "Don't write multi-paragraph docstrings or multi-line comment blocks — one short line max."

The added block is 5 lines and includes historical narrative ("shipped clipped at the 560 default before being listed") that belongs in the PR description, not the source file. Suggest trimming to one line:

// Table-style packs need 760pt for MappingTableContent's five columns; add new table packs here.
let widePacks: Set = [

The warning for future authors survives; the incident history moves to git log where it belongs.

---

2. Regression test not updated (should fix)

testPreferredDetailWidth_WidePacksReturn760() only asserts two of the eight wide packs. The newly added pack isn't included, so a future accidental deletion of the neovim-terminal line would pass the test suite undetected.

Tests/KeyPathTests/PackInstallerRenderTests.swift around line 255:

// Before
let widePacks = ["com.keypath.pack.vim-navigation", "com.keypath.pack.window-snapping"]

// After — add the new entry
let widePacks = [
    "com.keypath.pack.vim-navigation",
    "com.keypath.pack.neovim-terminal",
    "com.keypath.pack.window-snapping",
]

(The other six packs in the allowlist could also be added for completeness, but neovim-terminal is the minimum for this PR.)

---

No concerns on

• Correctness — 760pt is the right width for MappingTableContent; the set lookup is the right mechanism.
• Performance — Set.contains is O(1).
• Security — no concerns.
• Sequences pack — correctly excluded (description-only detail, 560 default fits); well documented in the PR body.
• Structural debt — the allowlist-vs-derived-width TODO is appropriately deferred and flagged in the PR description.

---

Verdict: Fix comment to one line, add neovim-terminal to the test's widePacks array, then this is good to merge.