indexer,api: log non-actionable failures at warn, not error#679
Open
nikw9944 wants to merge 1 commit into
Open
indexer,api: log non-actionable failures at warn, not error#679nikw9944 wants to merge 1 commit into
nikw9944 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
lake-api-errors/lake-indexer-errorsalerts fire on trueERR-level log lines. A few code paths log atErrorfor conditions that are self-recovering or already handled, so they raise alerts despite needing no human action. This lowers those toWarnso only genuinely-actionable failures alert.workflow interrupted, reattaching(dzingest.go,rollup.go,solingest.go): the long-running workflow future returned an error and the code reattaches — routine on worker restarts/deploys. Real crash-loops are already covered by the separatelake-indexer-crash-loop/-downalerts.Error→Warn.swap rate: oracle fetch failed, serving stale cache(swap_rate.go): a handled fallback — it serves the cached rate and returns success.Error→Warn. The sibling "no cached fallback" path (which returns 502) stays atError.No behavior change beyond log severity.
Testing Verification
ERRlines: these messages appear there today (i.e. they currently alert) and are non-actionable.Follow-ups (not in this PR)
Activity erroratERR(staging). The clean fix (mirror dzingest's return-nil + failure-threshold) must stay backfill-safe (BackfillRollupWorkflowrelies on error propagation/retries), so it needs a live-vs-backfill-aware design + tests.