api,web: add service-aware path visualization (RFC-18)#618
Open
ben-malbeclabs wants to merge 1 commit into
Open
api,web: add service-aware path visualization (RFC-18)#618ben-malbeclabs wants to merge 1 commit into
ben-malbeclabs wants to merge 1 commit into
Conversation
|
🔗 Preview: https://pr-618.data.malbeclabs.com |
ben-malbeclabs
force-pushed
the
bc/service-aware-paths
branch
from
5a95506 to
bb87f04
Compare
Resolve traced paths through the IS-IS topology that matches the
selected traffic type. Unicast uses flex-algo 128 (topology-tagged,
non-drained links only); multicast uses algo 0 (all links). The same
node pair can therefore show different paths per service.
- api: loadTopologyGraph / findKShortestPaths / FetchMetroPathLatencyData
take a service param; unicast filters out untagged and drained links
- web: Unicast/Multicast toggle on the path calculator, the device-path
panel, and the metro-path ("Find Paths") tool, with the selection
persisted in the URL
Closes malbeclabs/doublezero#3358
ben-malbeclabs
force-pushed
the
bc/service-aware-paths
branch
from
bb87f04 to
60fbe8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
servicequery parameter (unicast|multicast) to all path-finding API endpoints (/api/topology/paths, metro path latency, metro path detail, metro paths, metro device paths) — unicast excludes links with emptylink_topologiesand drained links (flex-algo 128 constrained topology), multicast includes all links (algo 0)Closes malbeclabs/doublezero#3358
Testing Verification
go build ./api/...andgo vet ./api/...passbun tsc --noEmitpasses for web (pre-existing radix-ui errors unrelated)UNICAST-DEFAULTand 2 untagged — unicast mode will exclude the 2 untagged links, producing different paths when those links are on the routeservice,path_service) persist across navigation and "View in graph" deep links