web/api: show agent versions on device detail page#534
Draft
nikw9944 wants to merge 2 commits into
Draft
Conversation
Register controller_agent_versions as external remote table proxies for mainnet-beta, devnet, and testnet. This allows Lake to query agent and controller version info written by the controller service.
Display telemetry agent, config agent, and controller versions on the device detail page. Telemetry agent version comes from fact_dz_device_link_latency_sample_header; config agent and controller versions come from the controller_agent_versions proxy table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
controller_agent_versionsas external remote table proxies for mainnet-beta, devnet, and testnet environments/dz/devices/<pk>), queryingfact_dz_device_link_latency_sample_headerfor telemetry and the newcontroller_agent_versionsproxy table for config agent/controller versionscontroller_agent_versionsReplacingMergeTree table to the controllerDiff Breakdown
Small feature — API queries + frontend display with scaffolding for remote table registration.
Key files (click to expand)
api/handlers/devices.go— Add version fields to DeviceDetail struct; query telemetry agent version from latency sample headers and config agent/controller version from controller_agent_versions proxy tableweb/src/components/device-detail-page.tsx— Show telemetry agent, config agent, and controller version cards on device detail pageweb/src/lib/api.ts— Add version fields to DeviceDetail TypeScript interfaceadmin/remotetables/setup.go— Register controller_agent_versions proxy tables for all three environmentsClickHouse Grants
The Lake remote user needs SELECT on the new table in each environment (one-time manual grant):
Testing Verification
TestGetDevice_ReturnsDetails,TestGetDevice_IncludesContributorInfo,TestGetDevice_IncludesTrafficRates