e2e/qa: run testnet shred-subscription settlement on solana devnet#3965
Open
nikw9944 wants to merge 3 commits into
Open
e2e/qa: run testnet shred-subscription settlement on solana devnet#3965nikw9944 wants to merge 3 commits into
nikw9944 wants to merge 3 commits into
Conversation
The testnet shred-subscription program moved from the DZ Ledger testnet to Solana devnet. Stop forcing the testnet settlement RPC onto the DZ ledger so --url (and the USDC balance / program-state reads) resolve to networkConfig.SolanaRPCURL, which SOLANA_RPC_URL overrides to the Solana devnet RPC endpoint at run time. DZ devnet is unchanged. Point the testnet USDC mint at the Solana devnet mint so GetUSDCBalance derives the right ATA and --usdc-mint carries the correct mint. Serviceability still flows over --dz-ledger-url (DZ Ledger testnet), unchanged. Part of malbeclabs/infra#1761 / epic malbeclabs/infra#1758.
nikw9944
force-pushed
the
qa-settlement-solana-devnet
branch
from
8f9a709 to
f838035
Compare
karl-dz
approved these changes
Jul 1, 2026
The settlement test's query_seat_price ran 'doublezero-solana shreds price' without a device filter, which resolves device codes via serviceability. The CLI refuses code resolution when it can't classify the cluster (a private Solana devnet RPC URL is seen as localnet), failing the query. Pass the closest device's pubkey through FeedSeatPrice so the agent runs 'shreds price --device <pubkey>', which skips code resolution. Match the returned price by pubkey since code may be absent. pay/withdraw already use --device, so this makes the whole settlement path code-resolution-free. Part of malbeclabs/infra#1761 / epic malbeclabs/infra#1758.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
TestQA_MulticastSettlementexercise the shred-subscription program on Solana devnet for testnet, instead of the DZ Ledger. Part of malbeclabs/infra#1761 / epic #1758; depends on the shred-oracle being live on devnet.client.go— narrow the DZ-ledgerSolanaRPCURLoverride to devnet only, so testnet resolves--urlfromnetworkConfig.SolanaRPCURL(set via theSOLANA_RPC_URLenv in the QA runner; the in-repo default stays a public endpoint).config/constants.go— pointTestnetUSDCMintat the Solana devnet USDC mint.Why keep
--usdc-mint(deviates from the issue)The issue suggested dropping
--usdc-mintfor CLI auto-detection, butGetUSDCBalancederives the wallet ATA fromc.USDCMint, so the test needs the concrete mint regardless. Keeping one value inTestnetUSDCMint(used for both the CLI arg and the balance check) is simpler than splitting the source of truth; the passed mint matches what auto-detect would resolve.Note
TestnetSolanaRPCis intentionally left unchanged — it's also consumed byconfig/solana.go, so the endpoint override rides onSOLANA_RPC_URLinstead.