Skip to content

Remove "supress"#354

Open
kasanari wants to merge 2 commits into
mainfrom
remove_supress
Open

Remove "supress"#354
kasanari wants to merge 2 commits into
mainfrom
remove_supress

Conversation

@kasanari

@kasanari kasanari commented May 28, 2026

Copy link
Copy Markdown
Collaborator

Not sure what this is a remain of, but I am not using it and it seems to overlap in functionality with actionability.

@kasanari kasanari requested a review from mrkickling May 28, 2026 06:59
@kasanari

Copy link
Copy Markdown
Collaborator Author

A test failed, so it is apparently supporting something...

@mrkickling

Copy link
Copy Markdown
Contributor

coreLang uses it as a tag on certain defenses to hide them. Should we just ignore the tag?

@kasanari

kasanari commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

My feeling would be that since that is CoreLang-specific, any user that needs that behavior could create their scenarios with action-ability based on the tags. I do not like the thought of the simulator having checks that are specific to CoreLang, but perhaps the 'suspend' check can be moved to the scenario creation code where it gets converted into actionability.

@mrkickling

Copy link
Copy Markdown
Contributor

I can add actionability to the affected scenarios and see if the tests pass

@mrkickling

Copy link
Copy Markdown
Contributor

Did it now. But this could be seen as a breaking change since coreLang users that do not use actionability will get new actions in their defense surface once we release this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants