feat(config): vf config memory accepts builtin|claude-mem|off#505
Merged
Conversation
Closes #490 Signed-off-by: magicpro97 <magicpro97@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Updates the vf config memory subcommand to support explicit memory backend modes (builtin, claude-mem, off) while preserving backward compatibility for on → builtin, aligning CLI UX with the builtin memory recall plan (Issue #490).
Changes:
- Extend
vf config memoryto acceptbuiltin|claude-mem|off(plusonas an alias forbuiltin) and print the active mode name in status/output. - Update CLI help text to document the new modes and semantics.
- Expand tests to cover the new modes and updated output expectations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/config.test.ts | Updates/extends tests for new memory mode values and status output behavior. |
| src/commands/help.ts | Updates help/usage strings to reflect `builtin |
| src/commands/config-decision.ts | Implements new mode parsing/validation and updates status/output formatting to print mode names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #490