feat(memory): wire recall into vf plan#504
Closed
magicpro97 wants to merge 1 commit into
Closed
Conversation
Closes #489 Signed-off-by: magicpro97 <magicpro97@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR closes #489 by wiring the memory recall system into vf plan so relevant past decisions can be included alongside the brief’s §2 non‑negotiables in the generated planning prompt.
Changes:
- Extend
buildPlanPrompt()to accept an optionalmemoryBlockand append it beside §2 Non‑negotiables. - In
plan(), read repo settings, resolve the configured memory provider, recall top hits for the artifact, and render them into the prompt. - Add unit tests for
buildPlanPrompt()memory block inclusion/exclusion and re-exportbuildPlanPromptfor test access.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/commands/plan.ts |
Adds optional memory block support in buildPlanPrompt and wires settings-driven memory recall into plan(). |
src/commands.ts |
Re-exports buildPlanPrompt so tests (and other callers) can import it. |
test/commands-plan.test.ts |
Adds direct tests validating buildPlanPrompt includes/omits the memory block. |
Comment on lines
+167
to
+170
| const base = cwd(); | ||
| const settings = readSettings(base); | ||
| const memProvider = resolveMemoryProvider(settings.memory, base); | ||
| const memBlock = memProvider ? renderMemoryBlock(memProvider.recall(artifact, { limit: 3 })) : ""; |
Comment on lines
+167
to
+171
| const base = cwd(); | ||
| const settings = readSettings(base); | ||
| const memProvider = resolveMemoryProvider(settings.memory, base); | ||
| const memBlock = memProvider ? renderMemoryBlock(memProvider.recall(artifact, { limit: 3 })) : ""; | ||
| const prompt = buildPlanPrompt(artifact, briefRaw, memBlock); |
Owner
Author
|
Superseded by #506 which also fixes ctxDir bug + bun:sqlite bundle leak. |
auto-merge was automatically disabled
July 2, 2026 11:05
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #489