feat(memory): wire recall into makeDispatcher#502
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements Issue #488’s “per-unit past-decision injection” by wiring memory recall into makeDispatcher, so each work unit’s generated CONTEXT.md can include a “Relevant past decisions” block when recall returns hits.
Changes:
- Add memory-provider resolution (from settings or injected seam), recall (
name+spec), and passmemoryBlockintobuildEnginePromptwithinmakeDispatcher. - Introduce a
memoryProvider?injection interface for tests/overrides. - Add tests covering prompt injection when the injected provider returns hits vs. returns no results.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/commands/dispatch-runtime.ts |
Resolves a memory provider, recalls per-unit memory, and passes a rendered memory block into the dispatch prompt generation. |
test/commands-coverage.test.ts |
Adds tests ensuring CONTEXT.md includes/excludes the “Relevant past decisions” block based on provider recall results. |
…ize-waiver to #503 Signed-off-by: magicpro97 <magicpro97@users.noreply.github.com>
magicpro97
force-pushed
the
feat/memory-make-dispatcher
branch
from
34f7d73 to
43c3b7b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #488