Skip to content

fix: associate trim validation errors with form fields#1537

Open
srinidhi-2006-bit wants to merge 1 commit into
magic-peach:mainfrom
srinidhi-2006-bit:fix-error-message-accessibility
Open

fix: associate trim validation errors with form fields#1537
srinidhi-2006-bit wants to merge 1 commit into
magic-peach:mainfrom
srinidhi-2006-bit:fix-error-message-accessibility

Conversation

@srinidhi-2006-bit
Copy link
Copy Markdown
Contributor

@srinidhi-2006-bit srinidhi-2006-bit commented Jun 5, 2026

Description

Improved accessibility of trim validation fields by properly associating validation errors with their corresponding form inputs.

Changes Made

  • Added role="alert" to trim validation error messages
  • Verified aria-describedby links inputs to their error messages
  • Verified aria-invalid is set on invalid inputs
  • Ensured screen readers can announce validation errors correctly

Accessibility Improvements

  • Error messages are programmatically associated with form fields
  • Invalid fields expose their state through aria-invalid
  • Validation errors are announced using role="alert"

Related Issue

Fixes #172

Type of Contribution

  • Bug fix
  • New feature
  • Documentation update
  • Refactor
  • GSSoC contribution

Participant Info

  • GitHub username: srinidhi-2006-bit
  • Contribution level (Beginner)

Screen Recording

Recording / Loom link:

reframe_trim.mp4

Checklist

  • I have read the contribution guidelines
  • My changes follow the project structure
  • I have tested my changes in Chrome, Firefox, and Safari
  • bun run lint passes (no ESLint errors)
  • bunx tsc --noEmit passes (no TypeScript errors)
  • New interactive elements have aria-label / accessible names
  • No console.log statements left in
  • This PR is related to a valid issue
  • Screen recording attached above (required for UI/feature/design changes)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 5, 2026

@srinidhi-2006-bit is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

👋 Thanks for your PR, @srinidhi-2006-bit!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

🟠 GSSoC'26 PR detected — thanks for contributing under GirlScript Summer of Code 2026!

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor gssoc'26 GirlScript Summer of Code 2026 labels Jun 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 5, 2026

✅ PR Format Check Passed — @srinidhi-2006-bit

Basic format checks passed. A maintainer will review your code changes.

This does not mean the PR is approved — it just means the format is correct.

@srinidhi-2006-bit
Copy link
Copy Markdown
Contributor Author

Hi @magic-peach

I've completed the accessibility fix for Issue #172.

Changes made

  • Added role="alert" to trim validation error messages
  • Verified aria-describedby correctly links inputs to their error messages
  • Verified aria-invalid is set on invalid fields

Validation

  • CI build passed ✅
  • Lint passed ✅
  • Type check passed ✅
  • Screen recording attached ✅

Please let me know if any further changes are needed. Thank you for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gssoc'26 GirlScript Summer of Code 2026 level:beginner Beginner level - 20 pts type:bug Bug fix type:design UI/UX design type:docs Documentation type:feature New feature type:refactor Code refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility] Ensure error messages are associated with form fields

1 participant