fix: associate trim validation errors with form fields#1537
Open
srinidhi-2006-bit wants to merge 1 commit into
Open
fix: associate trim validation errors with form fields#1537srinidhi-2006-bit wants to merge 1 commit into
srinidhi-2006-bit wants to merge 1 commit into
Conversation
|
@srinidhi-2006-bit is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
👋 Thanks for your PR, @srinidhi-2006-bit!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @srinidhi-2006-bitBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
Author
|
Hi @magic-peach I've completed the accessibility fix for Issue #172. Changes made
Validation
Please let me know if any further changes are needed. Thank you for your review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improved accessibility of trim validation fields by properly associating validation errors with their corresponding form inputs.
Changes Made
role="alert"to trim validation error messagesaria-describedbylinks inputs to their error messagesaria-invalidis set on invalid inputsAccessibility Improvements
aria-invalidrole="alert"Related Issue
Fixes #172
Type of Contribution
Participant Info
Screen Recording
Recording / Loom link:
reframe_trim.mp4
Checklist
bun run lintpasses (no ESLint errors)bunx tsc --noEmitpasses (no TypeScript errors)aria-label/ accessible namesconsole.logstatements left in