fix: add MIME type magic byte validation to prevent spoofed file uploads (#137)#1519
Open
sachin-mahato25 wants to merge 1 commit into
Open
fix: add MIME type magic byte validation to prevent spoofed file uploads (#137)#1519sachin-mahato25 wants to merge 1 commit into
sachin-mahato25 wants to merge 1 commit into
Conversation
|
@sachin-mahato25 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
✅ PR Format Check Passed — @sachin-mahato25Basic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
Contributor
👋 Thanks for your PR, @sachin-mahato25!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Author
|
Hey @magic-peach! I've worked on issue #137 and submitted a PR that adds magic byte validation to verify actual file headers instead of relying on extensions/MIME types. Tested with both fake and real video files. ✅ You can check it, verify and request for changes if needed. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #137
What changed
validateVideoMagicBytes()insrc/utils/video-validation.tsthat reads the first 12 bytes of the uploaded file and checks them against known video format magic byte signatureshandleFileinsrc/components/FileUpload.tsxto be async and call the magic byte check before processingFormats supported
ftypbox at byte offset 40x1A 0x45 0xDF 0xA3RIFFheaderOggSsignatureFLV\x01signature0x47ftyp3gat byte offset 4Testing
.txtfile to.mp4→ correctly rejected with error message.mp4video → loaded and processed normally