Skip to content

fix: resolve next.js production build compilation errors and worker type mismatches#1509

Open
thakurakanksha288 wants to merge 2 commits into
magic-peach:mainfrom
thakurakanksha288:fix/production-build-errors
Open

fix: resolve next.js production build compilation errors and worker type mismatches#1509
thakurakanksha288 wants to merge 2 commits into
magic-peach:mainfrom
thakurakanksha288:fix/production-build-errors

Conversation

@thakurakanksha288
Copy link
Copy Markdown

Description

This PR resolves several critical TypeScript compiler errors, ESLint accessibility blocks, and Webpack caching issues that were preventing the production build (npm run build) from completing successfully.

Changes Made

  • VideoPreview.tsx: Addressed ESLint jsx-a11y rules for interactive element tracking and matched the framing check to the correct strict "fill" | "fit" types.
  • ffmpeg.worker.ts: Implemented a fallback WorkerContext inline interface to bypass missing global DedicatedWorkerGlobalScope types without modifying global configuration scopes.
  • constants.ts & frame-export.ts: Unified the recipe data layer by updating legacy rotate property references to the typed rotation field.
  • textOverlay.ts: Addressed an optional fallback block by casting the overlay reference dynamically, and mathematically aligned the FFmpeg drawtext coordinates (tw/2, th/2) with the UI's center-origin layout.

Verification

  • Wiped the Next.js and Webpack disk caches cleanly.
  • Successfully ran npm run build with zero compilation errors.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 2, 2026

@thakurakanksha288 is attempting to deploy a commit to the magic-peach1's projects Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

⚠️ PR Format Issues — @thakurakanksha288

Please fix the following before your PR can be reviewed:

  • ⚠️ No linked issue found. Add Closes #<issue-number> to your PR description.

Push new commits after fixing — this comment will update automatically.

📖 CONTRIBUTING.md

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 2, 2026

👋 Thanks for your PR, @thakurakanksha288!

Welcome to Reframe — a browser-based video editor built for everyone 🎬

What happens next

  1. 🤖 Automated checks — build & TypeScript typecheck will run automatically
  2. Vercel preview — a preview deployment will be created (requires maintainer authorization for fork PRs)
  3. 👀 Code review — a maintainer will review your changes
  4. 🚀 Merge — once approved, your PR will be merged!

Quick checklist

  • PR title follows Conventional Commits (e.g. feat: add dark mode)
  • Linked the issue this PR closes (e.g. Closes #123)
  • Tested the changes locally (bun run dev)
  • Build passes (bun run build)

Useful links

Happy coding! 🎉

@github-actions github-actions Bot added level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design labels Jun 2, 2026
@thakurakanksha288
Copy link
Copy Markdown
Author

Hi @magic-peach,

Thank you for reviewing my PR. I noticed that the checks are currently showing "5 workflows awaiting approval" and the build status is still pending, while Vercel deployment requires authorization. Since external contributor workflows require maintainer approval, could you please approve the pending GitHub Actions workflows so the remaining checks can run?

Thank you for your time and support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

level:advanced Advanced level - 55 pts type:bug Bug fix type:design UI/UX design

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant