fix(preview): prevent memory leak and CPU overhead in thumbnail generator by aborting video stream and adding timeout fallback #1505
Open
AdityaNarayanPadhi wants to merge 1 commit into
Conversation
…ator by aborting video stream and adding timeout fallback (magic-peach#1500)
|
@AdityaNarayanPadhi is attempting to deploy a commit to the magic-peach1's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Contributor
👋 Thanks for your PR, @AdityaNarayanPadhi!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prevents memory leaks and background CPU overhead in the offscreen thumbnail generator caused by stalled seek operations when new videos are uploaded or components unmount (#1500).
Changes
cancelThumbnailRuninThumbnailStrip.tsxto immediately set the source of the offscreen video element to""and invokeload(). This halts active media loading/decoding instantly and clears occupied hardware/software decoder slots.generateThumbnails. If a seek stalls, the promise resolves and allows the loop to exit and clean up rather than hanging indefinitely.Verification