fix: add packageManager field for pnpm/action-setup@v4 - #2
Merged
Conversation
The pnpm/action-setup@v4 action requires a pnpm version to be specified either in the action config or via the packageManager field in package.json. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pnpm doesn't support --if-present like npm does. Removed the lint step since no lint script exists, and removed --if-present from test/build since those scripts do exist. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tests depend on assets/ directory which is generated by the build step (copy-assets.js). Also removed --if-present flags from release workflow since pnpm doesn't support them. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"packageManager": "pnpm@10.28.2"to rootpackage.jsonpnpm/action-setup@v4failing with "No pnpm version is specified" in bothdry-run.ymlandrelease-npm.ymlworkflowsTest plan
🤖 Generated with Claude Code