Add REST and GraphQL functional test workflows#138
Add REST and GraphQL functional test workflows#138gowrizrh wants to merge 2 commits intomage-os:mainfrom
Conversation
|
|
||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - name: Set PHP Version |
There was a problem hiding this comment.
This should be reworked to use the new setup-magento and cache-magento commands.
| tools: composer:v${{ matrix.composer }} | ||
| coverage: none | ||
|
|
||
| - run: composer create-project --repository-url="${{ inputs.magento_repository }}" "${{ matrix.magento }}" ${{ inputs.magento_directory }} --no-install |
There was a problem hiding this comment.
This should be reworked to use the new setup-magento and cache-magento commands.
|
@gowrizrh I'm revisiting this PR (many years later, I appreciate your contribution I promise). I've revisited my stance on public workflows, I'm leaning strongly now to a very finite and specific way of doing these workflows. I have a few questions based upon the contents of this PR. First, would you expect to run these for only a store or also an extension? Second, take a look at my new Check Extension workflow would you expect to be able to run these extension in isolation or only as a part of this workflow. I'm considering adding some kind of "feature" flags to this workflow to allow you to select what features actually run. |
2 participants
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Fixes: #97
What is the new behavior?
Does this PR introduce a breaking change?
Other information