60 add mps support - #61
Merged
Merged
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds explicit device selection support (
"cuda","mps","cpu") across the training and evaluation pipelines, enabling users on Apple Silicon to leverage the MPS backend. It also includes targeted DataLoader efficiency improvements.Device Selection
DeviceName = Literal["cuda", "mps", "cpu"]type alias toschemas/types.py.get_device()to accept an explicitdeviceargument instead of auto-detecting. Raises a clearValueErrorfor unavailable or misconfigured devices (e.g. CUDA not available, invaliddevice_index,device_indexpassed for MPS).deviceanddevice_indexparameters on bothTrainerandEvaluator. Thedevice_indexis only applicable whendevice="cuda"."cuda"string in PaSST's mel spectrogramautocastguard — replaced withx.device.typeso it works correctly on any device.DataLoader Efficiency
pin_memoryis now conditional ondevice.type == "cuda"in bothTrainerandEvaluator— avoids unsupported behavior on MPS and CPU.persistent_workers=True(whennum_workers > 0) to all DataLoaders — eliminates worker process spawn/kill overhead at every epoch boundary.pad_collate_fnto usetorch.stackwhen all waveforms in a batch have the same length (e.g. whensegment_durationis set), falling back topad_sequencefor variable-length batches.Documentation
deviceparameter with all supported options.