ci(benchmarks): skip flaky D2 wall-clock timing test in CI#22
Merged
Conversation
TestD2Parsing_100Components_Under30s occasionally exceeds its 30s threshold on shared GitHub Actions runners (observed 38.90s). Skip when CI=true. Also fix API golden test regression: GetBuildStatus included duration_ms for in-progress builds when queried on slower runners (value >0), but omitted it on fast machines (value 0). Remove the in-progress duration computation so the field only appears for completed builds, making the response shape stable across environments.
andhijeannot
force-pushed
the
fix/d2-timing-ci-skip
branch
from
0c074ae to
c9986a4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestD2Parsing_100Components_Under30s occasionally exceeds its 30s threshold on shared GitHub Actions runners (observed 38.90s). Skip when CI=true, leaving BenchmarkD2Parsing_100Components as the reliable signal.