011 toon mcp output#21
Merged
Merged
Conversation
…handling` **Details:** - **Rules file path:** Changed from `specs/009-constitution-compliance/contracts/structural-rules.yaml` to `tools/archcheck/rules.yaml` for centralized rule management. - **Suppression flags:** Added `--suppressions` to specify suppression files, and `--no-suppress` to bypass suppression logic entirely. - **Formatting:** Adjusted `--format` and `--report` flags for flexibility in output. - **Exit code:** Updated to handle suppressed violations gracefully (exit code 1 for violations, 0 for compliance). **Impact:** - Ensures consistent rule enforcement across the tool. - Provides flexibility for suppression rules while maintaining compliance checks. - Improves usability by allowing customization of output formats and suppression behavior.
Close the remaining test-infrastructure, baseline, and documentation gaps for the constitution-compliance feature (production refactor already at 0 archcheck violations, constitution v1.2.0). Golden / regression suites (run under go test ./... — no build tags): - tests/integration/api: HTTP API goldens for all /api/v1/* routes (T063/T064) - tests/integration/mcp: MCP smoke fixtures for 5 read tools (T005/T030) - tests/integration/cli: CLI goldens for init + validate (T004/T019) (new system|container|component left to use-case unit tests — template resolution is install-layout-sensitive; documented in the test) Baselines + coverage gate (T006/T007/T051): - coverage-baseline.txt, baseline-violations.json - fix scripts/coverage-delta.sh: it compared go-tool-cover-func output that has no per-package totals (silent no-op); now derives per-package coverage and genuinely detects regressions Docs (T032/T058/T059/T060/T065): - internal/mcp/tools/MIGRATION.md (tool -> use-case map) - README quality-gates section - docs/architecture/constitution-compliance.md (contributor reference) - quickstart-validation.md (SC-010 diagnostic-legibility + 0.07s benchmark) Bookkeeping: T039/T052 marked out-of-scope (referenced unbuilt --baseline/--include flags); T025 not needed; T056/T062 resolved. Verified: go test ./... green, task audit-constitution 0 violations, golangci-lint 0 issues, coverage-delta OK.
- Test query project with TOON format - Test query architecture with TOON format - Test search elements with TOON format - Validate error handling for invalid formats"
The .gitignore 'archcheck' pattern (added for build artifacts) also matched the tools/archcheck/ directory, causing suppression.go, suppression_test.go, and rules.yaml to be silently excluded from git. This broke CI compilation of the archcheck tool, which in turn failed the Test, Lint, and Constitution Audit jobs. Also force-add .archcheck-suppressions.yaml which contains the initial constitution v1.2.0 suppression entries and was similarly ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.