fix: fully drain request body on auth early-return to prevent connection leaks [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] - #4
Open
waterWang wants to merge 1 commit into
Conversation
…ion leaks
Replace io.CopyN(Discard, Body, 4096) with io.Copy(Discard, Body) so the
request body is drained to EOF before closing. A partial 4096-byte drain
leaves large/chunked request bodies unread; on HTTP keep-alive connections
the server treats those leftover bytes as belonging to the next request,
breaking ("leaking") the connection.
Also add a drain-to-EOF regression test (16 KiB body) and a nil-body safety
test, plus the minimal gin stub types needed for the repo's tests to compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes connection leak on failed BasicAuth.
Problem
When the BasicAuth middleware aborts an unauthorized request, it previously drained only 4096 bytes of the request body:
For requests with a body larger than 4 KiB (or chunked transfer), unread bytes remain on the socket. The HTTP server treats those leftover bytes as the start of the next request over the same keep-alive connection, breaking ("leaking") the connection.