fix: synchronize RoutePath with mutated URL.Path to prevent parameter loss - #9
Open
jamboriu wants to merge 1 commit into
Open
fix: synchronize RoutePath with mutated URL.Path to prevent parameter loss#9jamboriu wants to merge 1 commit into
jamboriu wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the URL parameter loss issue that occurs when middlewares rewrite
r.URL.Path(e.g., path rewriting, strip prefixes, URL normalization) before routing to sub-routers or handlers (resolving issue #1).Cause
In the
go-chi/chirouting cycle, sub-routing depends onrctx.RoutePath(which tracks the remaining path to match). However, standard middlewares modifyingr.URL.Pathdo not updaterctx.RoutePath, leading to out-of-sync routing contexts wherechi.URLParamqueries fail.Solution
URLPathtracking field tochi.Context(with proper cleanup inReset()) to detect whenr.URL.Pathhas been mutated.r.URL.Pathaccordingly. This handles both full path rewrites and partial/versioned prefix updates (e.g.,/api/v1->/api/v2).TestMiddlewarePathRewriteURLParams,TestSubrouterMiddlewarePathRewriteURLParams, andTestSubrouterPartialPathRewriteURLParamsverifying parameter extraction under various rewrite depths.Testing and Verification
go test -race ./...): All PASS (no regressions, no races).