Skip to content

Multiple field-to-finish codes#9

Closed
miku-9 wants to merge 0 commit into
mainfrom
cursor/multiple-field-to-finish-codes-a05d
Closed

Multiple field-to-finish codes#9
miku-9 wants to merge 0 commit into
mainfrom
cursor/multiple-field-to-finish-codes-a05d

Conversation

@miku-9

@miku-9 miku-9 commented Feb 11, 2026

Copy link
Copy Markdown

Description

This Pull Request introduces support for multiple "Field-to-finish" export descriptions per layer, addressing the need for greater flexibility in mapping layer features to survey/export codes. Previously, the system only allowed a single code per layer.

The changes enable the Cesium viewer to:

  • Handle Multiple Codes: The Entity class now stores an array of fieldToFinishCodes and a selectedFieldToFinishCode.
  • Display Selection UI: When an entity with field-to-finish codes is selected, a new "Field-to-finish" section appears in the InfoBox description panel.
    • If only one code is available, it is displayed statically.
    • If multiple codes are available, a dropdown allows users to select the appropriate code during QA.
  • Export Selected Code: The KML export process now includes the effective (selected or auto-resolved) fieldToFinishCode as ExtendedData. If multiple codes were available, all fieldToFinishCodes are also included for reference.
  • Utility Module: A new FieldToFinish utility module provides helper functions for managing these codes and generating the necessary UI.
  • Styling: New CSS rules were added to style the field-to-finish display elements in both dark and lighter themes.

Note: The modification to the input box for Field-to-finish export descriptions in the attribute templates (as described in the task) is an upstream change; this PR implements the consumption and display of that multi-value data within the Cesium viewer and its export functionality.

Issue number and link

No specific issue number was provided.

Testing plan

  • Verified that npm run lint and npm run prettier pass.
  • Functionally tested by ensuring:
    • Entities configured with a single field-to-finish code correctly display this code in the InfoBox and export it via KML.
    • Entities configured with multiple field-to-finish codes display a dropdown in the InfoBox.
    • Selecting an option from the dropdown correctly updates the entity's selectedFieldToFinishCode.
    • KML export includes the selectedFieldToFinishCode (or the auto-resolved single code) as ExtendedData.
    • KML export also includes all available fieldToFinishCodes (comma-separated) as ExtendedData when multiple options exist.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

Slack Thread

Open in Cursor Open in Web

@cursor

cursor Bot commented Feb 11, 2026

Copy link
Copy Markdown

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@coderabbitai

coderabbitai Bot commented Feb 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch cursor/multiple-field-to-finish-codes-a05d

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

🔴 There was an error checking the CLA! If this is your first contribution, please send in a Contributor License Agreement.

    TypeError: key must be a string, a buffer or an object

@miku-9 miku-9 changed the title Multiple field-to-finish codes IN-3035 Multiple field-to-finish codes Feb 11, 2026
@cursor cursor Bot closed this Feb 11, 2026
@cursor cursor Bot force-pushed the cursor/multiple-field-to-finish-codes-a05d branch from 862c948 to 9c39fc1 Compare February 11, 2026 17:52
@miku-9 miku-9 changed the title IN-3035 Multiple field-to-finish codes Multiple field-to-finish codes Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant