Skip to content

feat: GPU Binned spline calclaution - #1034

Open
KSkwarczynski wants to merge 3 commits into
developfrom
kskwarczynski/feat/GPUbinnedSplines
Open

feat: GPU Binned spline calclaution#1034
KSkwarczynski wants to merge 3 commits into
developfrom
kskwarczynski/feat/GPUbinnedSplines

Conversation

@KSkwarczynski

Copy link
Copy Markdown
Member

Pull request description

Unbinned for a while had ability to use GPU. For binned it wasn't used due to several reasons.

This PR finally add this feature for binned by mostly reusing existing code.

With this PR I also did some renaming and tweaks.
Due to historical reasons Binned and Unbinned converged to very similar structure. But all variables had different names and were minor differences. Final goal is to use SplineBase for as much as possible.

Examples

Doing validations one can see results are almost identical. Bots are complaining because of floating-point precision (GPU uses float only)
Validations


@KSkwarczynski KSkwarczynski self-assigned this Aug 21, 2026
@github-actions

Copy link
Copy Markdown

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions Bot added Documentation 📚 Improvements or additions to documentation Parameters ⚙️ Related with neutrino interactions or oscillations Samples 🗃️ GPU ⚡ Related to GPU acceleration labels Aug 21, 2026
@github-actions

github-actions Bot commented Aug 21, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@github-actions

Copy link
Copy Markdown

Hi, I am MaCh3-Telemetry bot

Memory and CPU Usage Summary

### Memory and CPU Usage Summary

| Metric  |     Mean    |      Max    |
|---------|-------------|-------------|
| **RAM** |   358.88 MB |   367.02 MB |
| **CPU** |    96.38 %  |    98.00 %  |

Memory Usage Plot

You can view the memory usage plot directly in the job summary from the link above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation 📚 Improvements or additions to documentation GPU ⚡ Related to GPU acceleration Parameters ⚙️ Related with neutrino interactions or oscillations Samples 🗃️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant