Skip to content

breaking: Unified Random Number Generator - #1025

Open
KSkwarczynski wants to merge 7 commits into
developfrom
kskwarczynski/breaking/randomNumber
Open

breaking: Unified Random Number Generator#1025
KSkwarczynski wants to merge 7 commits into
developfrom
kskwarczynski/breaking/randomNumber

Conversation

@KSkwarczynski

Copy link
Copy Markdown
Member

Pull request description

To be able to reproduce MaCh3 chains introduced new way of accessing random number by singleton.
This mean it is much easier to reproduce problematic fit behaviour.

I sticked to TRandom based on tests, but we can in future quite easily switch to STL.

Yes, new approach is fully thread safe.

Credits to David and Luke for inspiration and suggestions

Examples

4 chains with same seed (10) run independently produces same posteriors.
image

I tried benchmarking new approach so it isn't slower than old one:

Bench [Benchmark.txt](https://github.com/user-attachments/files/31147560/Benchmark.txt)

@github-actions

Copy link
Copy Markdown

Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this

meme

Use this action on your projects. Use jokes on issues instead.

@github-actions github-actions Bot added Plotting 📊 plotting related MCMC 🎲 MCMC related Parameters ⚙️ Related with neutrino interactions or oscillations Samples 🗃️ Manager 🧠 labels Aug 17, 2026
@github-actions

github-actions Bot commented Aug 17, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@github-actions

Copy link
Copy Markdown

Hi, I am MaCh3-Telemetry bot

Memory and CPU Usage Summary

### Memory and CPU Usage Summary

| Metric  |     Mean    |      Max    |
|---------|-------------|-------------|
| **RAM** |   357.23 MB |   365.09 MB |
| **CPU** |    96.38 %  |    97.75 %  |

Memory Usage Plot

You can view the memory usage plot directly in the job summary from the link above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Manager 🧠 MCMC 🎲 MCMC related Parameters ⚙️ Related with neutrino interactions or oscillations Plotting 📊 plotting related Samples 🗃️

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant