breaking: Unified Random Number Generator - #1025
Open
KSkwarczynski wants to merge 7 commits into
Open
Conversation
KSkwarczynski
requested review from
henry-wallace-phys and
luketpickering
as code owners
August 17, 2026 16:48
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this Use this action on your projects. Use jokes on issues instead. |
Super-linter summary
All files and directories linted successfully For more information, see the GitHub Actions workflow run Powered by Super-linter |
|
Hi, I am MaCh3-Telemetry bot Memory and CPU Usage SummaryMemory Usage PlotYou can view the memory usage plot directly in the job summary from the link above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pull request description
To be able to reproduce MaCh3 chains introduced new way of accessing random number by singleton.
This mean it is much easier to reproduce problematic fit behaviour.
I sticked to TRandom based on tests, but we can in future quite easily switch to STL.
Yes, new approach is fully thread safe.
Credits to David and Luke for inspiration and suggestions
Examples
4 chains with same seed (10) run independently produces same posteriors.

I tried benchmarking new approach so it isn't slower than old one: