fix(ci): build the package without re-running the selftest - #13
Merged
Conversation
v0.4.0 published with no package: the job failed in check(), which runs bin/aikit-selftest. In a build container 40 of its 61 checks fail for want of tmux, sqlite, gh and a session -- for want of an environment, not for want of correctness. The selftest is not being skipped. It is its own job in ci.yml and has to be green before anything reaches main; it passed on the PR that added this package. Running it a second time somewhere it structurally cannot work only ever produces a false red, and a false red on the packaging job means a release with no package -- which is the whole bug this feature exists to fix. check() stays in the PKGBUILD: someone building by hand on a real machine has the environment and should get the check. Only the container skips it, and the comment says why this repo's copy of the job differs from the other four. A test pins both halves: --nocheck in the workflow, and aikit-selftest still a job in ci.yml. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SYBhT1xfp3MQ1w3687F4Mp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.4.0 published with no package: the job died in
check(), which runsbin/aikit-selftest.It needs tmux, sqlite, gh and a session. In a build container it fails for want of an environment, not of correctness.
The selftest is not being skipped. It is its own job in
ci.yml, has to be green before anything reachesmain, and passed on #11. Running it a second time somewhere it structurally cannot work only ever produces a false red — and a false red here means a release with no package, which is the bug this feature exists to fix.check()stays in the PKGBUILD so a manual build on a real machine still gets it. Only the container skips it, and the comment says why this repo's copy of the job differs from the other four.🤖 Generated with Claude Code
https://claude.ai/code/session_01SYBhT1xfp3MQ1w3687F4Mp