Skip to content

feat: add message pane aware context menu - #355

Open
dcoffin88 wants to merge 1 commit into
maathimself:mainfrom
dcoffin88:feat-message-pane-context-menu
Open

feat: add message pane aware context menu#355
dcoffin88 wants to merge 1 commit into
maathimself:mainfrom
dcoffin88:feat-message-pane-context-menu

Conversation

@dcoffin88

Copy link
Copy Markdown
Contributor

Summary

This PR adds a context menu to the message pane, providing common actions within email content. Originally for #301 but also improves main app.

Changes

  • Added a message pane context menu.
  • Copy copies the current text selection from the message pane, matching standard text-selection behaviour, and is disabled when nothing is selected.
  • Select All selects the entire message, including HTML emails rendered inside iframes.
  • Find opens an in-app search dialog to search within the currently open message, automatically scrolling to and selecting matches.
  • Context menu handling ensures a stale text selection elsewhere in the application does not prevent the message pane context menu from opening.

Testing

Tested on my production environment using both plain-text and HTML emails.

Contributor License Agreement

By submitting this pull request I confirm that:

  • I have read and agree to the Contributor License Agreement.
  • My contribution is my own original work (or I have identified any
    third-party material and confirmed it is compatible with the CLA).
  • I have the right to submit this contribution under the terms of the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant