fix linux update flow - #346
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses a bug identified during testing for Native apps: security hardening before the first signed release #301.
The downloaded
.deband.rpmpackages open successfully in the system package installer. However, Ubuntu App Center and Fedora Software treat MailFlow as already installed and expose only an Uninstall or Remove action. They do not provide an Install or Update action for the newer local package.The package metadata itself is correct. On Ubuntu/Fedora, the upgrade succeeds when run through APT/DNF:
APT/DNF correctly detects it as an upgrade from version 0.0.1 to version 0.0.2.
Changes
The Linux update flow has been changed from an Install button to an installation-instructions message.
The message provides a Copy install command button, so the user can paste the verified command into a terminal and complete the update manually.
For Debian/Ubuntu:
sudo apt install "$HOME/Downloads/MailFlow-0.0.0-amd64.deb"For Fedora/RHEL:
sudo dnf install "$HOME/Downloads/MailFlow-0.0.0-x86_64.rpm"MailFlow downloads and verifies the package but does not automatically invoke
sudo,apt,dnf,dpkg, orrpm.This avoids unattended privilege elevation while still providing users with a clear update path when the graphical package installer does not support upgrading a local package.
Testing
[x] Tested the .deb update flow on Ubuntu.
[x] Tested the .rpm update flow on Fedora.
[x] Confirmed the installation command is copied correctly.
[x] Confirmed APT recognizes the .deb as an upgrade.
[x] Confirmed DNF recognizes the .rpm as an upgrade.
[x] Confirmed MailFlow does not automatically invoke privileged package-manager commands.
Contributor License Agreement
By submitting this pull request I confirm that:
third-party material and confirmed it is compatible with the CLA).