Skip to content

feat: Add PaymentExtension-to-Mono-Repo#776

Merged
BrandonStalnaker merged 1 commit into
mainfrom
feat/Add-PaymentExtension-to-Mono-Repo
May 28, 2026
Merged

feat: Add PaymentExtension-to-Mono-Repo#776
BrandonStalnaker merged 1 commit into
mainfrom
feat/Add-PaymentExtension-to-Mono-Repo

Conversation

@BrandonStalnaker
Copy link
Copy Markdown
Collaborator

Background

  • Move the Payment Extension repo into the mono repo and mirror it the original repo for release.

What Has Changed

  • Added in the rokt-payment-extension repor and updated the CI to support releasing and testing it.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this May 28, 2026
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner May 28, 2026 13:43
@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

High Risk
Introduces live payment flows (Stripe, Apple Pay, redirect URLs) and changes release mirroring (force-push) and CocoaPods ordering—mistakes affect partner checkouts and published artifacts.

Overview
Adds RoktPaymentExtension under Kits/rokt-payment-extension/rokt-payment-extension-ios as a first-class kit: Stripe-backed Apple Pay/card and Afterpay/Clearpay via PaymentExtension, with urlScheme + Info.plist validation, filtered redirect handling, unit tests, and mirror to ROKT/rokt-payment-extension-ios.

RoktSDKPlus now pins RoktPaymentExtension to the same ecosystem semver as mParticle (SPM/CocoaPods), with local monorepo paths when USE_LOCAL_VERSION is set—replacing the separate 2.x line.

Release/CI: Kits/matrix.json registers the new kit (pod_lint_standalone, mirror_force_push_main, ROKT org); pod lint can omit core podspecs and optionally add related podspecs; draft bumps payment extension Package.swift version; publish may force-push mirror main and waits for RoktPaymentExtension on CocoaPods before RoktSDKPlus; docs updated in RELEASE.md.

Reviewed by Cursor Bugbot for commit c688ca2. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 28, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.77 MB 1.77 MB +N/A
Executable Impact 848 bytes 848 bytes +N/A
XCFramework Size 6.45 MB 6.45 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1900,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1816,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6604}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1900,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1816,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6604}

Comment thread Kits/rokt-sdk-plus/rokt-sdk-plus-ios/Package.swift
@BrandonStalnaker BrandonStalnaker force-pushed the feat/Add-PaymentExtension-to-Mono-Repo branch from 26e2b64 to c688ca2 Compare May 28, 2026 13:54
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c688ca2. Configure here.

Copy link
Copy Markdown
Contributor

@nickolas-dimitrakas nickolas-dimitrakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BrandonStalnaker BrandonStalnaker merged commit 57085c0 into main May 28, 2026
147 of 148 checks passed
@BrandonStalnaker BrandonStalnaker deleted the feat/Add-PaymentExtension-to-Mono-Repo branch May 28, 2026 14:28
@BrandonStalnaker BrandonStalnaker restored the feat/Add-PaymentExtension-to-Mono-Repo branch May 28, 2026 14:56
BrandonStalnaker added a commit that referenced this pull request May 28, 2026
Revert "feat: Add PaymentExtension-to-Mono-Repo (#776)"

This reverts commit 57085c0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants