Skip to content

fix: call start on kits configured from cache#774

Merged
BrandonStalnaker merged 1 commit into
mainfrom
fix/start-cached-kits
May 21, 2026
Merged

fix: call start on kits configured from cache#774
BrandonStalnaker merged 1 commit into
mainfrom
fix/start-cached-kits

Conversation

@BrandonStalnaker
Copy link
Copy Markdown
Collaborator

Background

  • Kits configured by cached cofigurations did not have start called on them. This was not a problem with the majority of the kits as they no longer use a start method, but Braze, when initialization was not handled by the customer, did fail to start in this scenario

What Has Changed

  • This change ensures that no matter the path for receiving a configuration we attempt to call start on all kits.

Checklist

  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have tested this locally.

Reference Issue (For employees only. Ignore if you are an outside contributor)

@BrandonStalnaker BrandonStalnaker self-assigned this May 21, 2026
@BrandonStalnaker BrandonStalnaker requested a review from a team as a code owner May 21, 2026 13:53
@cursor
Copy link
Copy Markdown

cursor Bot commented May 21, 2026

PR Summary

Low Risk
Low risk control-flow change that centralizes when start is invoked for kit instances; main risk is unintended extra/earlier start calls for kits that previously relied on deferred initialization.

Overview
Ensures kit instances get a consistent start attempt during configureKits, regardless of whether the kit was newly created or already had an existing instance.

The start/setLaunchOptions: logic is moved to a single post-configuration block and now skips starting when the kit is disabled, preventing disabled kits from being started while fixing kits that were configured but never started.

Reviewed by Cursor Bugbot for commit 326a23d. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bdb41d7. Configure here.

Comment thread mParticle-Apple-SDK/Kits/MPKitContainer.m
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026

📦 SDK Size Impact Report

Measures how much the SDK adds to an app's size (with-SDK minus without-SDK).

Metric Target Branch This PR Change
App Bundle Impact 1.77 MB 1.77 MB +N/A
Executable Impact 848 bytes 848 bytes +N/A
XCFramework Size 6.45 MB 6.45 MB +N/A

➡️ SDK size impact change is minimal.

Raw measurements

Target branch (main):

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1900,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1816,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6604}

This PR:

{"baseline_app_size_kb":84,"baseline_executable_size_bytes":75464,"with_sdk_app_size_kb":1900,"with_sdk_executable_size_bytes":76312,"sdk_impact_kb":1816,"sdk_executable_impact_bytes":848,"xcframework_size_kb":6604}

@BrandonStalnaker BrandonStalnaker force-pushed the fix/start-cached-kits branch from bdb41d7 to 326a23d Compare May 21, 2026 13:59
@BrandonStalnaker BrandonStalnaker merged commit 0dd039c into main May 21, 2026
212 of 214 checks passed
@BrandonStalnaker BrandonStalnaker deleted the fix/start-cached-kits branch May 21, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants