(LPS/LTS)2(PBES/PRES) logging: Clearer message for warning#1935
Open
jacenre wants to merge 1 commit into
Open
Conversation
jkeiren
reviewed
May 28, 2026
jkeiren
left a comment
jkeiren
left a comment
Collaborator
There was a problem hiding this comment.
Make sure to update the remaining language issues.
Also, if there is only 1 action in the diff, technically the message should still be singular. Have a look elsewhere if we print the message singular or not, and make sure we are consistent here.
| << " that does not appear in the LPS!" << std::endl; | ||
| mCRL2log(log::warning) << "Warning: the modal formula contains actions " | ||
| << core::detail::print_list(diff) | ||
| << " that are in the data specification, but does not appear in the LPS!" << std::endl; |
| << " that does not appear in the LPS!" << std::endl; | ||
| mCRL2log(log::warning) << "Warning: the modal formula contains actions " | ||
| << core::detail::print_list(diff) | ||
| << " that are in the data specification, but does not appear in the LPS!" << std::endl; |
| << " that does not appear in the LTS!" << std::endl; | ||
| mCRL2log(log::warning) << "Warning: the modal formula contains actions " | ||
| << core::detail::print_list(diff) | ||
| << " that are in the data specification, but does not appear in the LTS!" << std::endl; |
| << " that does not appear in the LTS!" << std::endl; | ||
| mCRL2log(log::warning) << "Warning: the modal formula contains actions " | ||
| << core::detail::print_list(diff) | ||
| << " that are in the data specification, but does not appear in the LTS!" << std::endl; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, it sounds like one is trying to use actions that do not exist.
Instead, the actions are defined, but they do not appear in the LPS/LTS.
Also, print the entire list to improve the usefulness of the warning.