fix(elf): make Note::type_to_str namespace-aware - #531
Closed
wyf027 wants to merge 1 commit into
Closed
Conversation
ELF note type constants such as NT_VERSION (1), NT_GNU_ABI_TAG (1), and NT_PRSTATUS (1) share the same numeric value but belong to different namespaces. Resolve the type string based on n_name instead of n_type alone, following elf(5). Fixes #410 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note::type_to_strresolve note types based on the note namespace (n_name) instead ofn_typealoneNT_VERSIONandNT_ARCHconstants for the default/unknown namespaceFixes #410
Test plan
cargo test --features alloc elf::note::teststype_to_str_respects_namespacecovering GNU/default/CORE disambiguation for type value1