Rearchitect review runtime and presentation ownership

.github/workflows/ci.yml

@@ -20,13 +20,16 @@ concurrency:
   group: ci-${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+env:
+  DEVELOPER_DIR: /Applications/Xcode_26.6.0.app/Contents/Developer
+  EXPECTED_XCODE_VERSION_LINE: Xcode 26.6
+  EXPECTED_XCODE_BUILD_LINE: Build version 17F113
+
 jobs:
-  package-tests:
-    name: Package Tests (macOS)
+  api-contract:
+    name: API Contract (macOS)
     runs-on: macos-26
     timeout-minutes: 10
-    env:
-      XCODE_MAJOR: '26'
     steps:
       - name: Check out repository
         uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
@@ -36,49 +39,170 @@ jobs:
       - name: Verify GitHub Actions pinning
         run: ruby scripts/verify-github-actions-pinning.rb
 
-      - name: Resolve latest stable Xcode
+      - name: Verify pinned Xcode
+        run: scripts/verify-ci-xcode.sh
+
+      - name: Verify TextTransitions public API
+        run: scripts/verify-text-transitions-api.sh
+
+  package-build:
+    name: Package Test Build (macOS)
+    runs-on: macos-26
+    timeout-minutes: 10
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
+        with:
+          persist-credentials: false
+
+      - name: Verify pinned Xcode
+        id: toolchain
+        run: scripts/verify-ci-xcode.sh
+
+      - name: Restore SwiftPM build cache
+        uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
+        with:
+          path: .build
+          key: spm-build-v1-debug-swiftbuild-${{ runner.os }}-${{ runner.arch }}-${{ steps.toolchain.outputs.cache-id }}-${{ hashFiles('Package.swift', 'Package.resolved') }}-${{ github.sha }}
+          restore-keys: |
+            spm-build-v1-debug-swiftbuild-${{ runner.os }}-${{ runner.arch }}-${{ steps.toolchain.outputs.cache-id }}-${{ hashFiles('Package.swift', 'Package.resolved') }}-
+
+      - name: Restore source modification times
+        run: scripts/restore-source-mtimes.sh
+
+      - name: Build package tests
+        run: swift build --build-tests --build-system swiftbuild
+
+  package-tests:
+    name: Package Tests (macOS, ${{ matrix.shard }})
+    needs: package-build
+    runs-on: macos-26
+    timeout-minutes: 10
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - shard: CodexReviewKitTests
+            filter: CodexReviewKitTests
+            skip: ''
+          - shard: CodexReviewAppServerTests
+            filter: CodexReviewAppServerTests
+            skip: ''
+          - shard: CodexReviewMCPServerTests
+            filter: CodexReviewMCPServerTests
+            skip: ''
+          - shard: CodexReviewHostTests-a-d
+            filter: '^CodexReviewHostTests\.CodexReviewHostTests/liveStore[A-D]'
+            skip: ''
+          - shard: CodexReviewHostTests-e-j
+            filter: '^CodexReviewHostTests\.CodexReviewHostTests/liveStore[E-J]'
+            skip: ''
+          - shard: CodexReviewHostTests-k-r
+            filter: '^CodexReviewHostTests\.CodexReviewHostTests/liveStore[K-R]'
+            skip: ''
+          - shard: CodexReviewHostTests-remaining
+            filter: '^CodexReviewHostTests\.'
+            skip: '^CodexReviewHostTests\.CodexReviewHostTests/liveStore[A-R]'
+          - shard: ReviewUITests
+            filter: ReviewUITests
+            skip: ''
+          - shard: remaining
+            filter: ''
+            skip: 'CodexReviewKitTests|CodexReviewAppServerTests|CodexReviewMCPServerTests|CodexReviewHostTests|ReviewUITests'
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
+        with:
+          persist-credentials: false
+
+      - name: Verify pinned Xcode
+        id: toolchain
+        run: scripts/verify-ci-xcode.sh
+
+      - name: Restore built package tests
+        uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
+        with:
+          path: .build
+          key: spm-build-v1-debug-swiftbuild-${{ runner.os }}-${{ runner.arch }}-${{ steps.toolchain.outputs.cache-id }}-${{ hashFiles('Package.swift', 'Package.resolved') }}-${{ github.sha }}
+          fail-on-cache-miss: true
+
+      - name: Run package test shard
+        env:
+          TEST_FILTER: ${{ matrix.filter }}
+          TEST_SKIP: ${{ matrix.skip }}
         run: |
-          xcode_app="$(ruby <<'RUBY'
-          xcode_major = ENV.fetch("XCODE_MAJOR")
-          candidates = Dir["/Applications/Xcode_#{xcode_major}*.app"].select { |path| File.directory?(path) }
-
-          def pre_release_xcode_path?(path)
-            labels = [path, File.realpath(path)].map { |candidate| File.basename(candidate).downcase }
-            labels.any? do |label|
-              label.match?(/beta|release[ _-]?candidate|(?:^|[_. -])rc(?:$|[_. -])/)
-            end
-          end
-
-          candidates = candidates.reject do |path|
-            pre_release_xcode_path?(path)
-          end
-
-          def version_components(path)
-            version = File.basename(path)[/Xcode_(\d+(?:\.\d+)*)/, 1]
-            version.to_s.split(".").map(&:to_i)
-          end
-
-          selected = candidates.max_by { |path| version_components(path) }
-          abort("No stable Xcode #{xcode_major} installation found") unless selected
-          puts selected
-          RUBY
-          )"
-          echo "DEVELOPER_DIR=${xcode_app}/Contents/Developer" >> "$GITHUB_ENV"
-          echo "Resolved Xcode: ${xcode_app}"
-
-      - name: Show Xcode environment
+          args=(
+            --skip-build
+            --build-system swiftbuild
+            --no-parallel
+          )
+          [[ -z "$TEST_FILTER" ]] || args+=(--filter "$TEST_FILTER")
+          [[ -z "$TEST_SKIP" ]] || args+=(--skip "$TEST_SKIP")
+          swift test "${args[@]}"
+
+  monitor-build:
+    name: ReviewMonitor Test Build (macOS)
+    runs-on: macos-26
+    timeout-minutes: 10
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
+        with:
+          persist-credentials: false
+
+      - name: Verify pinned Xcode
+        id: toolchain
+        run: scripts/verify-ci-xcode.sh
+
+      - name: Restore ReviewMonitor build cache
+        uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
+        with:
+          path: .ci-build/review-monitor-derived-data
+          key: review-monitor-build-v1-${{ runner.os }}-${{ runner.arch }}-${{ steps.toolchain.outputs.cache-id }}-${{ hashFiles('Package.swift', 'Package.resolved', 'Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj/**') }}-${{ github.sha }}
+          restore-keys: |
+            review-monitor-build-v1-${{ runner.os }}-${{ runner.arch }}-${{ steps.toolchain.outputs.cache-id }}-${{ hashFiles('Package.swift', 'Package.resolved', 'Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj/**') }}-
+
+      - name: Restore source modification times
+        run: scripts/restore-source-mtimes.sh
+
+      - name: Build ReviewMonitor tests
         run: |
-          xcodebuild -version
-          xcodebuild -showsdks
+          xcodebuild build-for-testing \
+            -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj \
+            -scheme CodexReviewMonitor \
+            -destination 'platform=macOS,arch=arm64' \
+            -derivedDataPath .ci-build/review-monitor-derived-data \
+            CODE_SIGNING_ALLOWED=NO \
+            CODE_SIGNING_REQUIRED=NO
+
+  monitor-tests:
+    name: ReviewMonitor Tests (macOS)
+    needs: monitor-build
+    runs-on: macos-26
+    timeout-minutes: 10
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@df4cb1c069e1874edd31b4311f1884172cec0e10 # v6
+        with:
+          persist-credentials: false
+
+      - name: Verify pinned Xcode
+        id: toolchain
+        run: scripts/verify-ci-xcode.sh
 
-      - name: Run Swift package tests
-        run: swift test --build-system swiftbuild --no-parallel
+      - name: Restore built ReviewMonitor tests
+        uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v6.1.0
+        with:
+          path: .ci-build/review-monitor-derived-data
+          key: review-monitor-build-v1-${{ runner.os }}-${{ runner.arch }}-${{ steps.toolchain.outputs.cache-id }}-${{ hashFiles('Package.swift', 'Package.resolved', 'Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj/**') }}-${{ github.sha }}
+          fail-on-cache-miss: true
 
-      - name: Run monitor app tests
+      - name: Run ReviewMonitor tests
         run: |
-          xcodebuild test \
+          xcodebuild test-without-building \
             -project Tools/ReviewMonitor/CodexReviewMonitor.xcodeproj \
             -scheme CodexReviewMonitor \
             -destination 'platform=macOS,arch=arm64' \
+            -derivedDataPath .ci-build/review-monitor-derived-data \
             CODE_SIGNING_ALLOWED=NO \
             CODE_SIGNING_REQUIRED=NO