thumbnail-loader: fall back to external thumbnailers when built-in fails#122
Open
j4np0l wants to merge 1 commit into
Open
thumbnail-loader: fall back to external thumbnailers when built-in fails#122j4np0l wants to merge 1 commit into
j4np0l wants to merge 1 commit into
Conversation
When fm_file_info_is_image() returns TRUE (e.g. for image/x-exr, image/vnd.radiance, image/vnd.dxf), generate_thumbnails() entered the built-in path exclusively. If GdkPixbuf could not load the file, generate_thumbnails_with_builtin() returned FALSE but the return value was ignored, so external thumbnailers registered for those MIME types were never invoked. Fix: check the return value and fall through to generate_thumbnails_with_thumbnailers() on failure. Fixes: lxde/pcmanfm#51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fm_file_info_is_image() returns TRUE (e.g. for image/x-exr, image/vnd.radiance, image/vnd.dxf), generate_thumbnails() entered the built-in path exclusively. If GdkPixbuf could not load the file, generate_thumbnails_with_builtin() returned FALSE but the return value was ignored, so external thumbnailers registered for those MIME types were never invoked.
Fix: check the return value and fall through to generate_thumbnails_with_thumbnailers() on failure.
Fixes: lxde/pcmanfm#51