[WRONG BRANCH] fix: enforce native chat effort caps without pins - #469
[WRONG BRANCH] fix: enforce native chat effort caps without pins#469luvs01 wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
✅ Deterministic PR hygiene checks passed. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
⏳ DRAFT
What to do
Its title has been prefixed with |
Motivation
effortcaps when an operator pin resolved, which let qualifying unpinned requests bypass configured hard ceilings and raise upstream inference effort. This change restores the documented hard-ceiling semantics for v2 and spawned-child turns.Description
pinnedvalue resolved by moving cap logic outside the pin-only branch insrc/server/chat-native.tsand ensuring wire normalization runs when either a pin or cap changes the effort.normalizeForWireflag so provider wire mapping viamapReasoningEfforthappens whenever pinning or capping altered the effective effort, preserving passthrough spelling for unqualified caller values.tests/codex-integration/model-pinned-effort.test.tsto assert that a qualifying unpinned spawned-child request is capped (ultra->low) while an otherwise identical unqualified request still preserves the caller spelling.Testing
bun run typecheckand it passed.bun run privacy:scanand it passed.git diff --checkand it passed.bun test tests/codex-integration/model-pinned-effort.test.tsbut test collection failed in the current environment because the available Bun runtime lacks thenode:zlibzstdDecompressSyncexport; the updated test is included in the PR and will be exercised by CI where the expected Bun runtime is available.Codex Task