aws-cf-reverse-proxy: optional WAFv2 web_acl_id#68
Merged
Conversation
Add an optional 'web_acl_id' variable on aws-cf-reverse-proxy that is threaded straight through to aws_cloudfront_distribution.site.web_acl_id. Default null preserves the existing behaviour for every caller (no WAF attached). Callers can now attach a CLOUDFRONT-scope WAFv2 Web ACL ARN (IP denylist + rate limit + AWS managed rules, etc.) by setting the input. README documents the wire-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional `web_acl_id` input on `aws-cf-reverse-proxy` so callers can attach a CLOUDFRONT-scope WAFv2 Web ACL ARN to the underlying `aws_cloudfront_distribution.site`. Default `null` preserves the existing behaviour (no WAF attached) for every existing caller — fully additive, backward-compatible.
Why
Used by ui-infrastructure's upcoming WAFv2 rollout for `app.luthersystems.com` (prod) and `app-test.luthersystems.com` (staging), which front the EKS-hosted A2A / MCP / Oracle APIs. Today these have zero edge protection — a recent spammer hammered the anonymous A2A endpoint with 700+ tasks in 20 hours. This input is the wire-up step; the actual WAFv2 Web ACL + IP set + rate-limit + AWS managed rules land in ui-infrastructure on top of this.
Changes
Validation
Versioning / tag
Additive, backward-compatible → minor bump. Current tag is `v55.19.0` → intended next tag `v55.20.0` (to be cut by a human after merge — I am intentionally not pushing the tag from this PR). ui-infrastructure's companion PR pins this tag.
Test plan