fix: Eliminate perpetual Terraform drift in 4 AWS resources#59
Merged
Conversation
Add luthername tags to admin IAM role and Route53 zone (previously untagged), add lifecycle ignore for managed_policy_arns on the admin role, add lifecycle ignore for deprecated inline S3 bucket attributes, and set bucket_key_enabled = false on S3 encryption config to match AWS defaults. Closes #58 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws-platform-ui-bootstrap(previously untagged, causingtags = {}drift)lifecycle { ignore_changes = [managed_policy_arns] }on admin role to prevent drift from console-attached policieslifecycle { ignore_changes = [server_side_encryption_configuration, versioning] }on S3 bucket to suppress deprecated inline attribute driftbucket_key_enabled = falseon S3 encryption config to match AWS default and prevent driftCloses #58
Test plan
terraform fmt -check -recursivepassesterraform validatepasses in bothaws-platform-ui-bootstrap/andaws-s3-bucket/terraform planon cleancloud-provisionstage shows zero drift on these 4 resources🤖 Generated with Claude Code